Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when mapping memory

From	Juergen Gross <jgross@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when mapping memory
Date	2017-06-07 11:30 +0200
Message-ID	<tPFrQ-4M0-21@gated-at.bofh.it> (permalink)
References	<tNbxT-5ao-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 31/05/17 15:03, Julien Grall wrote:
> Commit 5995a68 "xen/privcmd: Add support for Linux 64KB page granularity" did
> not go far enough to support 64KB in mmap_batch_fn.
> 
> The variable 'nr' is the number of 4KB chunk to map. However, when Linux
> is using 64KB page granularity the array of pages (vma->vm_private_data)
> contain one page per 64KB. Fix it by incrementing st->index correctly.
> 
> Furthermore, st->va is not correctly incremented as PAGE_SIZE !=
> XEN_PAGE_SIZE.
> 
> Fixes: 5995a68 ("xen/privcmd: Add support for Linux 64KB page granularity")
> CC: stable@vger.kernel.org
> Reported-by: Feng Kan <fkan@apm.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Committed to xen.tip for-linus-4.12b


Juergen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xen/privcmd: Support correctly 64KB page granularity when mapping memory Julien Grall <julien.grall@arm.com> - 2017-05-31 15:10 +0200
  Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-05-31 16:00 +0200
    Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Julien Grall <julien.grall@arm.com> - 2017-06-01 15:00 +0200
      Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-06-01 15:40 +0200
        Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Julien Grall <julien.grall@arm.com> - 2017-06-01 16:10 +0200
          Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-06-01 17:20 +0200
            Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Julien Grall <julien.grall@arm.com> - 2017-06-01 17:40 +0200
              Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-06-01 22:50 +0200
                Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Julien Grall <julien.grall@arm.com> - 2017-06-06 18:20 +0200
  Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when  mapping memory Juergen Gross <jgross@suse.com> - 2017-06-07 11:30 +0200

csiph-web