Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1659576
| From | "Guillermo O. Freschi" <kedrot@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] drivers: staging/lustre: conrpc.c - fix sparse warning: warning: incorrect type in argument * (different address spaces) |
| Date | 2017-06-07 11:20 +0200 |
| Message-ID | <tPFib-4ID-29@gated-at.bofh.it> (permalink) |
| References | <tNM4q-40b-7@gated-at.bofh.it> <tPFia-4ID-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The calls to `copy_to_user` suggest that `ent` is pointing to userspace
memory, but `ent` is missing the `__user` qualifier.
Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
---
drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c
index f4578200994f..04a5d7e80151 100644
--- a/drivers/staging/lustre/lnet/selftest/conrpc.c
+++ b/drivers/staging/lustre/lnet/selftest/conrpc.c
@@ -469,7 +469,7 @@ lstcon_rpc_trans_interpreter(struct lstcon_rpc_trans *trans,
{
struct list_head tmp;
struct list_head __user *next;
- struct lstcon_rpc_ent *ent;
+ struct lstcon_rpc_ent __user *ent;
struct srpc_generic_reply *rep;
struct lstcon_rpc *crpc;
struct srpc_msg *msg;
--
2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [lustre-devel] [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces) "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-06-02 06:10 +0200
Re: [lustre-devel] [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces) Tordek <kedrot@gmail.com> - 2017-06-02 07:20 +0200
[PATCH 1/2] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces) "Guillermo O. Freschi" <kedrot@gmail.com> - 2017-06-07 11:20 +0200
[PATCH 2/2] drivers: staging/lustre: conrpc.c - fix sparse warning: warning: incorrect type in argument * (different address spaces) "Guillermo O. Freschi" <kedrot@gmail.com> - 2017-06-07 11:20 +0200
csiph-web