Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree

From	Hans Verkuil <hverkuil@xs4all.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree
Date	2017-06-07 11:20 +0200
Message-ID	<tPFia-4ID-15@gated-at.bofh.it> (permalink)
References	<tK8Ge-60t-5@gated-at.bofh.it> <tK8Ge-60t-9@gated-at.bofh.it> <tPEP8-4gO-19@gated-at.bofh.it> <tPEYO-4kE-5@gated-at.bofh.it> <tPF8u-4Fk-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/06/17 11:07, Matthias Brugger wrote:
> 
> 
> On 07/06/17 10:56, Hans Verkuil wrote:
>> On 07/06/17 10:44, Matthias Brugger wrote:
>>> Hi Hans, hi Mauro,
>>>
>>> On 23/05/17 05:24, Minghsiu Tsai wrote:
>>>> From: Daniel Kurtz <djkurtz@chromium.org>
>>>>
>>>> If the mdp_* nodes are under an mdp sub-node, their corresponding
>>>> platform device does not automatically get its iommu assigned properly.
>>>>
>>>> Fix this by moving the mdp component nodes up a level such that they are
>>>> siblings of mdp and all other SoC subsystems.  This also simplifies the
>>>> device tree.
>>>>
>>>> Although it fixes iommu assignment issue, it also break compatibility
>>>> with old device tree. So, the patch in driver is needed to iterate over
>>>> sibling mdp device nodes, not child ones, to keep driver work properly.
>>>>
>>>> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
>>>> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@mediatek.com>
>>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>>
>>>
>>> Are you OK to take this patch, or do you have any further comments?
>>
>> Nope, it's all good. Queued for 4.13.
>>
> 
> Thanks!
> 
> I queued the other two in v4.12-next/dts64

Media bindings normally go through the media subsystem, but you've taken
that one as well? I need to know, because then I drop it in my tree.

Regards,

	Hans

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree Matthias Brugger <matthias.bgg@gmail.com> - 2017-06-07 10:50 +0200
  Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree Hans Verkuil <hverkuil@xs4all.nl> - 2017-06-07 11:00 +0200
    Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree Matthias Brugger <matthias.bgg@gmail.com> - 2017-06-07 11:10 +0200
      Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree Matthias Brugger <matthias.bgg@gmail.com> - 2017-06-07 11:20 +0200
        Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree Hans Verkuil <hverkuil@xs4all.nl> - 2017-06-07 11:20 +0200
      Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree Hans Verkuil <hverkuil@xs4all.nl> - 2017-06-07 11:20 +0200

csiph-web