Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen
Date	2017-06-07 11:20 +0200
Message-ID	<tPFia-4ID-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <tMu9z-1fm-1@gated-at.bofh.it> <tMKo1-4Kd-5@gated-at.bofh.it> <tPhIR-68H-1@gated-at.bofh.it> <tPlt9-aF-29@gated-at.bofh.it> <tPnOi-1Aw-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jun 06, 2017 at 04:32:46PM +0200, Mylene Josserand wrote:
> > > Notice that the DT parsing uses a sysinfo's variable (si->num_btns)
> > > which is retrieved in the startup function (thanks to
> > > get_sysinfo). So, currently, it is not possible to move the startup
> > > function after the DT parsing.
> > 
> > Can't that be made the other way around? You parse the number of
> > buttons in the DT, and check the consistency with the hardware?
> 
> It could be possible but currently, it was designed to enable every button
> from hardware's configuration and DT binding was just a way to customize
> button's keycode (default is KEY_RESERVED).
> If I base it on the DT, it means that some buttons could never be reported
> (such as deactivated) because they will not be present in the DT. I am not
> sure if it is the behavior we want. What do you think?

I don't really know. Both look reasonable, and it seems to be more a
matter of policy. Dmitry?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen Mylène Josserand          <mylene.josserand@free-electrons.com> - 2017-05-29 16:50 +0200
  [PATCH] Input: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2017-05-29 19:20 +0200
  Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen kbuild test robot <lkp@intel.com> - 2017-05-29 19:20 +0200
  Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-30 10:10 +0200
    Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Mylene Josserand <mylene.josserand@free-electrons.com> - 2017-06-06 10:10 +0200
      Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-06 14:10 +0200
        Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Mylene Josserand <mylene.josserand@free-electrons.com> - 2017-06-06 16:40 +0200
          Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-07 11:20 +0200
  Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 10:20 +0200
  Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 10:50 +0200
    Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5  touchscreen Mylene Josserand <mylene.josserand@free-electrons.com> - 2017-06-06 15:30 +0200

csiph-web