Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper

From	Archit Taneja <architt@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper
Date	2017-06-07 10:20 +0200
Message-ID	<tPEm6-44h-19@gated-at.bofh.it> (permalink)
References	<tO1mN-5Va-11@gated-at.bofh.it> <tOX7s-1y2-9@gated-at.bofh.it> <tPnEB-1x7-13@gated-at.bofh.it> <tPnOj-1Aw-31@gated-at.bofh.it> <tPqVQ-3xj-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 06/06/2017 11:22 PM, Eric Anholt wrote:
> Maarten Lankhorst <maarten.lankhorst@linux.intel.com> writes:
>
>> This fixes the following depmod error when building drm as a module:
>> depmod: ERROR: Found 6 modules in dependency cycles!
>> depmod: ERROR: Cycle detected: drm -> drm_kms_helper -> drm
>>
>> Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.")
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Looks plausible to me.  Given how much trouble I've had getting the
> kbuild right, anyone else want to chime in?
>

The fix looks good to me too. depmod doesn't complain after this patch.

I can queue it to drm-misc-next if no one else has any comments on it
in the next few hours or so.

I'll make sure I check with 'make module_install' before pushing, I didn't
know depmod wasn't called otherwise.

Thanks,
Archit

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Thread

[PATCH v3] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge. Eric Anholt <eric@anholt.net> - 2017-06-02 22:30 +0200
  Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the  lvds-encoder bridge. Archit Taneja <architt@codeaurora.org> - 2017-06-05 12:10 +0200
    Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the  lvds-encoder bridge. Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2017-06-06 16:30 +0200
      [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2017-06-06 16:40 +0200
        Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper Eric Anholt <eric@anholt.net> - 2017-06-06 20:00 +0200
          Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper Archit Taneja <architt@codeaurora.org> - 2017-06-07 10:20 +0200
        RE: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper "Lofstedt, Marta" <marta.lofstedt@intel.com> - 2017-06-07 09:00 +0200
  Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the  lvds-encoder bridge. Thierry Reding <thierry.reding@gmail.com> - 2017-06-06 16:50 +0200

csiph-web