Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper
Date	2017-06-07 09:10 +0200
Message-ID	<tPDgl-3om-7@gated-at.bofh.it> (permalink)
References	<tPnOh-1Aw-3@gated-at.bofh.it> <tPnOh-1Aw-1@gated-at.bofh.it> <tProS-3Yv-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/06/2017 08:26 PM, Sagi Grimberg wrote:
> 
>> +    while ((offset < buflen) && sg_miter_next(&miter)) {
>> +        unsigned int len;
>> +
>> +        len = min(miter.length, buflen - offset);
>> +        memset(miter.addr, '\0', len);
> 
> Why '\0' and not 0?

Shouldn't be a difference, should it? ascii(7) says
'000   0     00    NUL '\0' (null character)'


-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 16:40 +0200
  Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper Sagi Grimberg <sagi@grimberg.me> - 2017-06-06 20:30 +0200
    Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-07 09:10 +0200

csiph-web