Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased pages
Date	2017-06-07 09:40 +0200
Message-ID	<tPDJo-3zy-27@gated-at.bofh.it> (permalink)
References	(7 earlier) <tIdqF-7Gg-13@gated-at.bofh.it> <tNiSK-1nX-17@gated-at.bofh.it> <tNmMG-4cv-15@gated-at.bofh.it> <tNyb8-32h-23@gated-at.bofh.it> <tNykO-35y-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 1 Jun 2017 15:21:15 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Thu, 1 Jun 2017 15:12:32 +0200
> Pavel Machek <pavel@ucw.cz> wrote:
> 
> > On Thu 2017-06-01 01:09:17, Darwin Dingel wrote:  
> > > Hi Pavel,
> > > 
> > > Just a minor thing. Sorry about the late comment.
> > > 
> > > On 01/06/17 08:59, Pavel Machek wrote:    
> > > > +
> > > > +		res = check_erased_page(chip, buf);
> > > > +		return res;
> > > > +	}    
> > > 
> > > Can we just remove 'res' and change this line to:
> > > 	return check_erased_page(chip, buf);    
> > 
> > Well... I originally had a printk there, and yes, it can be
> > simplified. I can roll v3, if required, but I'd leave it as is -- it
> > is still convenient place to add debugging to.  
> 
> I can fix it when applying, no need to send a new version.

Applied.

Thanks,

Boris

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased  pages Pavel Machek <pavel@ucw.cz> - 2017-05-31 23:00 +0200
  Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased  pages Darwin Dingel <Darwin.Dingel@alliedtelesis.co.nz> - 2017-06-01 01:00 +0200
  Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased  pages Darwin Dingel <Darwin.Dingel@alliedtelesis.co.nz> - 2017-06-01 03:10 +0200
    Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased  pages Pavel Machek <pavel@ucw.cz> - 2017-06-01 15:20 +0200
      Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in  erased pages Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-01 15:30 +0200
        Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in  erased pages Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-07 09:40 +0200

csiph-web