Re: [PATCH] mtd: nand: orion: Handle return value of clk_prepare_enable

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: orion: Handle return value of clk_prepare_enable
Date	2017-06-07 09:40 +0200
Message-ID	<tPDJn-3zy-9@gated-at.bofh.it> (permalink)
References	<tNvZD-1vK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu,  1 Jun 2017 16:28:15 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> clk_prepare_enable() can fail here and we must check its return value.
> 

Applied.

Thanks,

Boris

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/mtd/nand/orion_nand.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
> index f8e463a..209170e 100644
> --- a/drivers/mtd/nand/orion_nand.c
> +++ b/drivers/mtd/nand/orion_nand.c
> @@ -166,7 +166,11 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	clk_prepare_enable(info->clk);
> +	ret = clk_prepare_enable(info->clk);
> +	if (ret) {
> +		dev_err(&pdev->dev, "failed to prepare clock!\n");
> +		return ret;
> +	}
>  
>  	ret = nand_scan(mtd, 1);
>  	if (ret)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: orion: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-01 13:00 +0200
  Re: [PATCH] mtd: nand: orion: Handle return value of  clk_prepare_enable Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-07 09:40 +0200

csiph-web