Re: [PATCH v10] sun4i-codec: Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10] sun4i-codec: Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.
Date	2017-06-07 09:40 +0200
Message-ID	<tPDJn-3zy-1@gated-at.bofh.it> (permalink)
References	<tPDJn-3zy-3@gated-at.bofh.it> <tPDJn-3zy-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 7, 2017 at 3:27 PM, Danny Milosavljevic
<dannym@scratchpost.org> wrote:
> Adds support for some mixer controls to sun4i-codec:
>  - Line-In
>  - FM-In
>  - Mic 2
>  - Capture Source
>  - Differential Line-In
>
> It also adds a mux for the capture source and the PGA for the MIC2 preamp.
>
> Where possible, it uses SOC_DAPM_DOUBLE in order to cut down on the number
> of distinct controls in alsamixer.

You are doing too many things in one patch.

Please split this up into 1 patch per control/mux/source/widget added,
preceded by patches for any required cleanups.

ChenYu

> Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v10] sun4i-codec: Add mixer controls: Line-In, FM-In, Mic  2, Capture Source, Differential Line-In. Chen-Yu Tsai <wens@csie.org> - 2017-06-07 09:40 +0200

csiph-web