Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for bus_type

From	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for bus_type
Date	2017-06-07 08:00 +0200
Message-ID	<tPCaC-2s3-11@gated-at.bofh.it> (permalink)
References	<tPskV-4zc-3@gated-at.bofh.it> <tPskW-4zc-17@gated-at.bofh.it> <tPsuC-4DE-23@gated-at.bofh.it> <tPvLP-6UA-13@gated-at.bofh.it> <tPC0V-2oJ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-06-07 at 07:45 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 07, 2017 at 09:04:41AM +1000, Benjamin Herrenschmidt wrote:
> > On Tue, 2017-06-06 at 21:30 +0200, Greg Kroah-Hartman wrote:
> > > >   
> > > >   static struct device_attribute vio_dev_attrs[] = {
> > > >        __ATTR_RO(name),
> > > > @@ -1573,6 +1576,13 @@ static struct device_attribute vio_dev_attrs[] = {
> > > >        __ATTR_RO(modalias),
> > > >        __ATTR_NULL
> > > >   };
> > > > +static struct attribute *vio_dev_attrs[] = {
> > > 
> > > Hm, this feels wrong, odd that 0-day passed it.  I should be deleting
> > > the above vio_dev_attrs field as well.  Is powerpc really a dead
> > > platform?  :)
> > 
> > Haha, not yet no, and the above is actually still quite actively
> > in use as it's part of our hypervisor virtual IO infrastructure.
> 
> Ok, let me fix this, right after I emailed 0-day sent me the build error :)

Thanks !

Cheers,
Ben.

Thread

[PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for bus_type Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-06 21:30 +0200
  Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for  bus_type Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-06 21:40 +0200
    Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs  for bus_type Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-06-07 01:10 +0200
      Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for  bus_type Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-07 07:50 +0200
        Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs  for bus_type Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-06-07 08:00 +0200
    [PATCH 10/16 v2] powerpc: vio: use dev_groups and not dev_attrs for  bus_type Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-07 11:00 +0200

csiph-web