Re: [PATCH 1/1] genksyms: add printf format attribute to error_with_pos()

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] genksyms: add printf format attribute to error_with_pos()
Date	2017-06-06 01:50 +0200
Message-ID	<tP9UZ-YA-3@gated-at.bofh.it> (permalink)
References	<tJaK5-IK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-05-20 20:27 GMT+09:00 Nicolas Iooss <nicolas.iooss_linux@m4x.org>:
> When compiling with -Wsuggest-attribute=format in HOSTCFLAGS, gcc
> complains that error_with_pos() may be declared with a printf format
> attribute:
>
>     scripts/genksyms/genksyms.c:726:3: warning: function might be
>     possible candidate for ‘gnu_printf’ format attribute
>     [-Wsuggest-attribute=format]
>        vfprintf(stderr, fmt, args);
>        ^~~~~~~~
>
> This would allow catching printf-format errors at compile time in
> callers to error_with_pos(). Add this attribute.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>


Applied to linux-kbuild/fixes.  Thanks!



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] genksyms: add printf format attribute to error_with_pos() Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-06 01:50 +0200

csiph-web