Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies

From	Shuah Khan <shuah@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies
Date	2017-06-05 20:20 +0200
Message-ID	<tP4LE-6nG-15@gated-at.bofh.it> (permalink)
References	<tLstb-115-1@gated-at.bofh.it> <tLstc-115-29@gated-at.bofh.it> <tO0Ar-5nM-53@gated-at.bofh.it> <tOfg5-6l1-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Mickaël,

On 06/03/2017 05:13 AM, Mickaël Salaün wrote:
> Hi Shuah,
> 
> On 02/06/2017 21:31, Shuah Khan wrote:
>> Hi Mickaël,
>>
>> On 05/26/2017 12:43 PM, Mickaël Salaün wrote:
>>> Rebuild the seccomp tests when kselftest_harness.h is updated.
>>>
>>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>>> Acked-by: Kees Cook <keescook@chromium.org>
>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>> Cc: Shuah Khan <shuah@kernel.org>
>>> Cc: Will Drewry <wad@chromium.org>
>>> ---
>>>  tools/testing/selftests/seccomp/Makefile | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
>>> index 5fa6fd2246b1..aeb0c805f3ca 100644
>>> --- a/tools/testing/selftests/seccomp/Makefile
>>> +++ b/tools/testing/selftests/seccomp/Makefile
>>> @@ -4,3 +4,5 @@ LDFLAGS += -lpthread
>>>  
>>>  include ../lib.mk
>>>  
>>> +$(TEST_GEN_PROGS): seccomp_bpf.c ../kselftest_harness.h
>>> +	$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
>>>
>>
>> This change breaks seccomp build:
>>
>> make -C tools/testing/selftests/seccomp/
>> make: Entering directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp'
>> make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'.  Stop.
>> make: Leaving directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp'
>> shuah@mazurka:/mnt/data/lkml/linux_4.12$ cd tools/testing/selftests/seccomp/
>> shuah@mazurka:/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp$ make
>> make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'.  Stop.
>>
>>
>> Did you happen to try building with this change?
> 
> Yes I did, and it builds fine for me (with the same command and
> patches). There is only one warning from GCC with
> ../kselftest_harness.h:368 because of the trick from OPTIONAL_HANDLER(),
> which is intentional (and not modified by my patches).
> 
> I don't get why your "make" said that there is "No rule to make target"
> ../kselftest_harness.h . This file exists (patch 1/7) so there is no
> need to create it…
> gen_kselftest_tar.sh works fine too.
> 

I think I know what's going on here. It is my bad. Never mind, we are good.
I will apply this patch to linux-kselftest next.

thanks,
-- Shuah

Thread

[PATCH v5 0/7] Add kselftest_harness.h Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
  [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness documentation Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
    Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness documentation Kees Cook <keescook@chromium.org> - 2017-05-26 21:10 +0200
    Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness  documentation Shuah Khan <shuah@kernel.org> - 2017-06-02 22:10 +0200
      Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness  documentation Mickaël Salaün <mic@digikod.net> - 2017-06-03 13:20 +0200
        Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness  documentation Shuah Khan <shuah@kernel.org> - 2017-06-05 20:30 +0200
  [PATCH v5 4/7] Documentation/dev-tools: Add kselftest Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
  [PATCH v5 1/7] selftests: Make test_harness.h more generally available Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
  [PATCH v5 2/7] selftests: Cosmetic renames in kselftest_harness.h Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
  [PATCH v5 5/7] Documentation/dev-tools: Use reStructuredText markups for kselftest Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
  [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
    Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to  dependencies Shuah Khan <shuah@kernel.org> - 2017-06-02 21:40 +0200
      Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to  dependencies Mickaël Salaün <mic@digikod.net> - 2017-06-03 13:20 +0200
        Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to  dependencies Shuah Khan <shuah@kernel.org> - 2017-06-05 20:20 +0200
  [PATCH v5 6/7] selftests: Remove the TEST_API() wrapper from kselftest_harness.h Mickaël Salaün <mic@digikod.net> - 2017-05-26 20:50 +0200
    Re: [PATCH v5 6/7] selftests: Remove the TEST_API() wrapper from kselftest_harness.h Kees Cook <keescook@chromium.org> - 2017-05-26 21:10 +0200
  Re: [PATCH v5 0/7] Add kselftest_harness.h Kees Cook <keescook@chromium.org> - 2017-05-26 21:20 +0200
    Re: [PATCH v5 0/7] Add kselftest_harness.h Shuah Khan <shuah@kernel.org> - 2017-05-30 23:40 +0200

csiph-web