Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume
Date	2017-06-05 16:30 +0200
Message-ID	<tP1b4-41e-23@gated-at.bofh.it> (permalink)
References	<tGjJT-5NS-1@gated-at.bofh.it> <tGjJU-5NS-7@gated-at.bofh.it> <tNt1M-86d-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 01/06/2017 at 00:46:44 -0700, Stephen Boyd wrote:
> > +
> > +static u8 registered_ids[PMC_MAX_IDS];
> > +
> > +void pmc_register_id(u8 id)
> > +{
> 
> Shouldn't this also be inside CONFIG_PM? And then
> pmc_register_id() is a nop function when CONFIG_PM=n?
> 

I'll do that. I'll rebase on top of clk-next once you fix my silly
mistake.

> > +	int i;
> > +
> > +	for (i = 0; i < PMC_MAX_IDS; i++) {
> > +		if (registered_ids[i] == 0) {
> > +			registered_ids[i] = id;
> > +			break;
> > +		}
> > +		if (registered_ids[i] == id)
> > +			break;
> > +	}
> > +}
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume Stephen Boyd <sboyd@codeaurora.org> - 2017-06-01 09:50 +0200
  Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-05 16:30 +0200

csiph-web