Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1657631

Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted

Show all headers | View raw

From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Mon, 5 Jun 2017 13:10:19 +0200

> On Mon, Jun 05, 2017 at 01:53:23AM +0800, Icenowy Zheng wrote:
>> The EPHY may be already enabled by bootloaders which have Ethernet
>> capability (e.g. current U-Boot). Thus it should be reseted properly
>> before doing the enabling sequence in the dwmac-sun8i driver, otherwise
>> the EMAC reset process may fail if no cable is plugged, and then fail
>> the dwmac-sun8i probing.
>> 
>> Tested on Orange Pi PC, One and Zero. All the boards fail to have
>> dwmac-sun8i probed with "EMAC reset timeout" without cable plugged
>> before, and with this fix they're now all able to successfully probe the
>> EMAC without cable plugged and then use the connection after a cable is
>> hot-plugged in.
>> 
>> Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i")
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> 
> Thanks for the fix.
> Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> 
> Since I am the writter of the file, does I have the right to:
> Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> or
> Reviewed-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ?

Anyone whatsoever may contribute Acked-by and Reviewed-by tags to a
patch posting.

This is all documented in Documentation/process/submitting-patches.rst

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted Icenowy Zheng <icenowy@aosc.io> - 2017-06-04 20:00 +0200
  Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure the  EPHY is properly reseted Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-05 13:20 +0200
    Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure the  EPHY is properly reseted Andrew Lunn <andrew@lunn.ch> - 2017-06-05 14:50 +0200
    Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure  the EPHY is properly reseted David Miller <davem@davemloft.net> - 2017-06-05 16:30 +0200
  Re: [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is  properly reseted David Miller <davem@davemloft.net> - 2017-06-05 17:30 +0200

csiph-web