Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656900

Re: [PATCH v4 1/6] pinctrl: qcom: Add ipq8074 pinctrl driver

Show all headers | View raw

On Saturday, June 3, 2017 12:57:50 PM CEST Varadarajan Narayanan wrote:
> Add initial pinctrl driver to support pin configuration with
> pinctrl framework for ipq8074.
> 
> Signed-off-by: Manoharan Vijaya Raghavan <mraghava@codeaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
> ---
> +- bias-disable:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as no pull.
> +
> +- bias-pull-down:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as pull down.
> +
> +- bias-pull-up:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as pull up.
> +
> +#define REG_SIZE 0x1000
> +#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9)	\
> +	{					        \
> +		.name = "gpio" #id,			\
> +		.pins = gpio##id##_pins,		\
> +		.npins = (unsigned int)ARRAY_SIZE(gpio##id##_pins),	\
> +		.funcs = (int[]){			\
> +			msm_mux_gpio, /* gpio mode */	\
> +			msm_mux_##f1,			\
> +			msm_mux_##f2,			\
> +			msm_mux_##f3,			\
> +			msm_mux_##f4,			\
> +			msm_mux_##f5,			\
> +			msm_mux_##f6,			\
> +			msm_mux_##f7,			\
> +			msm_mux_##f8,			\
> +			msm_mux_##f9			\
> +		},				        \
> +		.nfuncs = 10,				\
> +		.ctl_reg = REG_SIZE * id,		\
> +		.io_reg = 0x4 + REG_SIZE * id,		\
> +		.intr_cfg_reg = 0x8 + REG_SIZE * id,		\
> +		.intr_status_reg = 0xc + REG_SIZE * id,	\
> +		.intr_target_reg = 0x8 + REG_SIZE * id,	\
> +		.mux_bit = 2,			\
> +		.pull_bit = 0,			\
> +		.drv_bit = 6,			\
> +		.oe_bit = 9,			\
> +		.in_bit = 0,			\
> +		.out_bit = 1,			\
> +		.intr_enable_bit = 0,		\
> +		.intr_status_bit = 0,		\
> +		.intr_target_bit = 5,		\
> +		.intr_raw_status_bit = 4,	\
> +		.intr_polarity_bit = 1,		\
> +		.intr_detection_bit = 2,	\
> +		.intr_detection_width = 2,	\
> +	}
> +
Hello,

Back in May, Ram Chandra Jangir posted a rather interesting patch on
the LEDE Mailing-List:
<https://www.mail-archive.com/lede-dev@lists.infradead.org/msg07691.html>
|GPIO_PULL bits configurations in TLMM_GPIO_CFG register
|differs for IPQ40xx from rest of the other qcom SoC's.
|This change add support to configure the msm_gpio_pull
|bits for ipq40xx, It is required to fix the proper
|configurations of gpio-pull bits for nand pins mux.
|
|IPQ40xx SoC:
|2'b10: Internal pull up enable.
|2'b11: Unsupport
|
|For other SoC's:
|2'b10: Keeper
|2'b11: Pull-Up

This information wasn't mentioned anywhere. In fact, the special pull-up
configuration was only discovered due to an issue with the qpic NAND on
the Cisco Meraki MR33. So I wonder what does the gpio-pull look like for
the IPQ8074? Is it the same as the IPQ40XX or does it follow the older 
SoCs?

I'm asking this because I'm preparing a modified version of this patch
that will be posted once the IPQ8074 is ready.

Regards,
Christian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/6] Add minimal boot support for IPQ8074 Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-03 09:30 +0200
  [PATCH v4 1/6] pinctrl: qcom: Add ipq8074 pinctrl driver Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-03 09:30 +0200
    Re: [PATCH v4 1/6] pinctrl: qcom: Add ipq8074 pinctrl driver Christian Lamparter <chunkeey@googlemail.com> - 2017-06-03 21:00 +0200
      Re: [PATCH v4 1/6] pinctrl: qcom: Add ipq8074 pinctrl driver Sricharan R <sricharan@codeaurora.org> - 2017-06-05 08:30 +0200
    Re: [PATCH v4 1/6] pinctrl: qcom: Add ipq8074 pinctrl driver Christian Lamparter <chunkeey@googlemail.com> - 2017-06-04 02:40 +0200
  [PATCH v4 3/6] clk: qcom: Add DT bindings for ipq8074 gcc clock controller Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-03 09:30 +0200
  [PATCH v4 5/6] arm64: dts: Add ipq8074 SoC and HK01 board support Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-03 09:30 +0200
  [PATCH v4 4/6] clk: qcom: Add ipq8074 Global Clock Controller support Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-03 09:30 +0200
  [PATCH v4 2/6] dt-bindings: qcom: Add ipq8074 bindings Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-03 09:40 +0200
  [PATCH v4 6/6] arm64: defconfig: Enable qcom ipq8074 clock and pinctrl Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-03 09:40 +0200

csiph-web