Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain
Date	2017-06-03 17:50 +0200
Message-ID	<tOjtn-mU-3@gated-at.bofh.it> (permalink)
References	<tNYIh-4cS-5@gated-at.bofh.it> <tNZXH-4Tg-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 2, 2017 at 9:52 PM, Franky Lin <franky.lin@broadcom.com> wrote:
> On Fri, Jun 2, 2017 at 10:22 AM, Peter S. Housel <housel@acm.org> wrote:

>>                 err = brcmf_sdiod_buffrw(sdiodev, SDIO_FUNC_2, false, addr,
>>                                          glom_skb);
>> -               if (err) {
>> -                       brcmu_pkt_buf_free_skb(glom_skb);
>> -                       goto done;
>> -               }

> What about
>         if (!err) {
>             skb_queue_walk(pktq, skb) {
>                 memcpy(skb->data, glom_skb->data, skb->len);
>                 skb_pull(glom_skb, skb->len);
>             }
>         }
>         brcmu_pkt_buf_free_skb(glom_skb);
>
> Then no goto is needed.

For my point of view it has two subtle inconveniences:
1. Not so usual pattern in use if (!ret)
2. Less error prone in case someone decides to expand the code and
missed ! or something else there.

Since both makes an approach less error prone I wouldn't suggest doing
that as I commented in new version.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain "Peter S. Housel" <housel@acm.org> - 2017-06-02 19:40 +0200
  Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain Florian Fainelli <f.fainelli@gmail.com> - 2017-06-02 20:50 +0200
  Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain Franky Lin <franky.lin@broadcom.com> - 2017-06-02 21:00 +0200
    [PATCH v2] brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain "Peter S. Housel" <housel@acm.org> - 2017-06-03 00:40 +0200
      Re: [PATCH v2] brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-03 17:40 +0200
    Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-03 17:50 +0200

csiph-web