[PATCH] vt: fix \e[2m using the wrong placeholder color on graphical consoles

From	Adam Borowski <kilobyte@angband.pl>
Newsgroups	linux.kernel
Subject	[PATCH] vt: fix \e[2m using the wrong placeholder color on graphical consoles
Date	2017-06-03 09:10 +0200
Message-ID	<tObm9-3Wi-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Only vgacon and sisusbcon did it right, the rest (via generic code) tried
underline (usually cyan).

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
Compare this if clause with the two above it.  Nice copypaste. :)

 drivers/tty/vt/vt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 9c9945284bcf..9309c7da660a 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -425,7 +425,7 @@ static u8 build_attr(struct vc_data *vc, u8 _color, u8 _intensity, u8 _blink,
 	else if (_underline)
 		a = (a & 0xf0) | vc->vc_ulcolor;
 	else if (_intensity == 0)
-		a = (a & 0xf0) | vc->vc_ulcolor;
+		a = (a & 0xf0) | vc->vc_halfcolor;
 	if (_reverse)
 		a = ((a) & 0x88) | ((((a) >> 4) | ((a) << 4)) & 0x77);
 	if (_blink)
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] vt: fix \e[2m using the wrong placeholder color on graphical consoles Adam Borowski <kilobyte@angband.pl> - 2017-06-03 09:10 +0200

csiph-web