Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657502
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs |
| Date | 2017-06-05 12:50 +0200 |
| Message-ID | <tOXK9-1L4-1@gated-at.bofh.it> (permalink) |
| References | <tNWn7-2Pu-3@gated-at.bofh.it> <tNWn7-2Pu-15@gated-at.bofh.it> <tOXAv-1HK-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2017-06-05 at 11:32 +0100, Lee Jones wrote: > On Fri, 02 Jun 2017, Richard Fitzgerald wrote: [] > > if (IS_ERR(madera->reset_gpio)) > > + ret = PTR_ERR(madera->reset_gpio); > > + else > > + ret = 0; > > If you pre-initialise ret, you can drop the else. Better to use: ret = PTR_ERR_OR_ZERO(madera->reset_gpio);
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v3 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2017-06-02 17:10 +0200 Re: [PATCH v3 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs Joe Perches <joe@perches.com> - 2017-06-05 12:50 +0200
csiph-web