Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657350
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mfd: tc6393xb: Handle return value of clk_prepare_enable |
| Date | 2017-06-05 10:20 +0200 |
| Message-ID | <tOVp0-nU-19@gated-at.bofh.it> (permalink) |
| References | <tNsyJ-7UU-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 01 Jun 2017, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/mfd/tc6393xb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c > index d16e71b..0c9f039 100644 > --- a/drivers/mfd/tc6393xb.c > +++ b/drivers/mfd/tc6393xb.c > @@ -797,7 +797,9 @@ static int tc6393xb_resume(struct platform_device *dev) > int ret; > int i; > > - clk_prepare_enable(tc6393xb->clk); > + ret = clk_prepare_enable(tc6393xb->clk); > + if (ret) > + return ret; > > ret = tcpd->resume(dev); > if (ret) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] mfd: tc6393xb: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-01 09:20 +0200 Re: [PATCH] mfd: tc6393xb: Handle return value of clk_prepare_enable Lee Jones <lee.jones@linaro.org> - 2017-06-05 10:20 +0200
csiph-web