Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1657340

[PATCH] fs: nfs: Fix a sleep-in-atomic bug in nfs_access_add_cache

Show all headers | View raw

The driver may sleep under a rcu read lock, and function call path is:
nfs_permission (acquire the lock by rcu_read_lock)
  nfs_do_access
    nfs_access_add_cache
      kmalloc(GFP_KERNEL) --> may sleep

To fix it, "GFP_KERNEL" is replaced with "GFP_ATOMIC".

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
 fs/nfs/dir.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 32ccd77..7a074db 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -2333,7 +2333,7 @@ static void nfs_access_add_rbtree(struct inode *inode, struct nfs_access_entry *
 
 void nfs_access_add_cache(struct inode *inode, struct nfs_access_entry *set)
 {
-	struct nfs_access_entry *cache = kmalloc(sizeof(*cache), GFP_KERNEL);
+	struct nfs_access_entry *cache = kmalloc(sizeof(*cache), GFP_ATOMIC);
 	if (cache == NULL)
 		return;
 	RB_CLEAR_NODE(&cache->rb_node);
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] fs: nfs: Fix a sleep-in-atomic bug in nfs_access_add_cache Jia-Ju Bai <baijiaju1990@163.com> - 2017-06-05 10:10 +0200
  Re: [PATCH] fs: nfs: Fix a sleep-in-atomic bug in  nfs_access_add_cache Trond Myklebust <trondmy@primarydata.com> - 2017-06-05 13:50 +0200
    Re: [PATCH] fs: nfs: Fix a sleep-in-atomic bug in nfs_access_add_cache Jia-Ju Bai <baijiaju1990@163.com> - 2017-06-05 14:40 +0200

csiph-web