Re: [PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user
Date	2017-06-05 08:50 +0200
Message-ID	<tOTZT-7QM-3@gated-at.bofh.it> (permalink)
References	<tObPc-45V-5@gated-at.bofh.it> <tOjtn-mU-7@gated-at.bofh.it> <tOTwS-7Hu-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 05, 2017 at 07:13:50AM +0100, Al Viro wrote:
> On Sun, Jun 04, 2017 at 12:42:52AM +0900, Greg Kroah-Hartman wrote:
> > On Sat, Jun 03, 2017 at 09:32:55AM +0200, Adam Borowski wrote:
> > > Hi!
> > > In a recent discussion, Linus and Al Viro said quite a bit of expletives
> > > about __put_user() and __get_user(), that it's a bad interface that's
> > > almost always the wrong thing to use:
> > > https://marc.info/?l=linux-kernel&m=149463725626316&w=2
> > > https://marc.info/?l=linux-kernel&m=149465866929092&w=2
> > > 
> > > Here's a few patches applying the lessons from that discussion to vt.
> > > None of the uses is performance-critical, but at least we get a nice bit
> > > of code simplification.  And, it's a start of manual review + conversion
> > > that Al Viro wants.
> > 
> > Ah, nice work, at first glance these all look good to me.  I'll queue
> > them up on Monday.
> 
> Could you put that into a separate no-rebase branch?  Or I could do that
> in vfs.git, for that matter...

If you just want to take these in vfs.git feel free to, I don't mind at
all:
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
that's probably the easiest.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user Adam Borowski <kilobyte@angband.pl> - 2017-06-03 09:40 +0200
  Re: [PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-03 17:50 +0200
    Re: [PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-05 08:20 +0200
      Re: [PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-05 08:50 +0200

csiph-web