Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups

From	kgunda@codeaurora.org
Newsgroups	linux.kernel
Subject	Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups
Date	2017-06-05 08:40 +0200
Message-ID	<tOTQe-7Nw-3@gated-at.bofh.it> (permalink)
References	<tMOKZ-7oW-9@gated-at.bofh.it> <tMOL1-7oW-41@gated-at.bofh.it> <tN0VP-6xv-1@gated-at.bofh.it> <tNBC1-58o-21@gated-at.bofh.it> <tNZEm-4Mu-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-06-03 00:01, Stephen Boyd wrote:
> On 06/01, kgunda@codeaurora.org wrote:
>> On 2017-05-31 07:14, Stephen Boyd wrote:
>> >On 05/30, Kiran Gunda wrote:
>> >>diff --git a/drivers/spmi/spmi-pmic-arb.c
>> >>b/drivers/spmi/spmi-pmic-arb.c
>> >>index 7201611..6320f1f 100644
>> >>--- a/drivers/spmi/spmi-pmic-arb.c
>> >>+++ b/drivers/spmi/spmi-pmic-arb.c
>> >>@@ -657,42 +659,6 @@ struct spmi_pmic_arb_irq_spec {
>> >> 	unsigned irq:3;
>> >> };
>> >>
>> >>-static int search_mapping_table(struct spmi_pmic_arb *pa,
>> >>-				struct spmi_pmic_arb_irq_spec *spec,
>> >
>> >Perhaps the spec should be removed at some point if this was the
>> >only place it was passed to.
>> >
>> Yes. This is passed only in this function. You want to remove this
>> structure and pass the slave, per and irq as function parameters?
>> If so we will do it in the next patch.
> 
> We don't pass it anywhere though? So I'm just saying have local
> variables instead of the structure.
Sure. Thanks for the clarification.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V1 04/15] spmi: pmic-arb: optimize table lookups Kiran Gunda <kgunda@codeaurora.org> - 2017-05-30 14:50 +0200
  Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups Stephen Boyd <sboyd@codeaurora.org> - 2017-05-31 03:50 +0200
    Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups kgunda@codeaurora.org - 2017-06-01 19:00 +0200
      Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups Stephen Boyd <sboyd@codeaurora.org> - 2017-06-02 20:40 +0200
        Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups kgunda@codeaurora.org - 2017-06-05 08:40 +0200

csiph-web