Re: [PATCH v1 7/8] powerpc/Kconfig: Enable STRICT_KERNEL_RWX

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 7/8] powerpc/Kconfig: Enable STRICT_KERNEL_RWX
Date	2017-06-05 07:50 +0200
Message-ID	<tOT3P-7eE-5@gated-at.bofh.it> (permalink)
References	<tMnUt-5tp-3@gated-at.bofh.it> <tMnUt-5tp-1@gated-at.bofh.it> <tOa6K-30H-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Balbir Singh <bsingharora@gmail.com> writes:
> On Mon, May 29, 2017 at 6:00 PM, Christophe LEROY
> <christophe.leroy@c-s.fr> wrote:
>> Le 25/05/2017 à 18:45, kbuild test robot a écrit :
>>> All errors (new ones prefixed by >>):
>>>
>>>>> kernel//power/snapshot.c:40:28: fatal error: asm/set_memory.h: No such
>>>>> file or directory
>>>
>>>      #include <asm/set_memory.h>
>>
>>
>> Looks like it is linked to commit 50327ddfb ("kernel/power/snapshot.c: use
>> set_memory.h header").
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=50327ddfb
>>
>> I believe that inclusion should be conditional to
>> CONFIG_ARCH_HAS_SET_MEMORY, which is not set by powerpc arch, just like in
>> include/linux/filter.c
>>
> Agreed, it needs to be fixed in kernel/power/sanpshot.c

It should be fixed in asm-generic/set_memory.h, there should be no need
to guard an include of a generic header.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 7/8] powerpc/Kconfig: Enable STRICT_KERNEL_RWX Christophe LEROY <christophe.leroy@c-s.fr> - 2017-05-29 10:10 +0200
  Re: [PATCH v1 7/8] powerpc/Kconfig: Enable STRICT_KERNEL_RWX Balbir Singh <bsingharora@gmail.com> - 2017-06-03 07:50 +0200
    Re: [PATCH v1 7/8] powerpc/Kconfig: Enable STRICT_KERNEL_RWX Michael Ellerman <mpe@ellerman.id.au> - 2017-06-05 07:50 +0200

csiph-web