Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1657282

Re: [PATCH v4 3/8] nvmet: implement namespace identify descriptor list

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH v4 3/8] nvmet: implement namespace identify descriptor list
Date 2017-06-05 07:40 +0200
Message-ID <tOSUb-79A-25@gated-at.bofh.it> (permalink)
References <tOB6V-3JJ-5@gated-at.bofh.it> <tOB6W-3JJ-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


I think this needs to zero the remainder of the 4k
buffer, quoting the spec:

"The controller may return any number of variable length Namespace
Identification Descriptor structures that fit into the 4096 byte Identify
payload. All remaining bytes after the namespace identification descriptor
structures should be cleared to 0h, and the host shall interpret a
Namespace Identifier Descriptor Length (NIDL) value of 0h as the end of
the list. If the hosts sees an unknown descriptor type it should
continue parsing the structure."

It could be easily done by copying the zero page to userspace.
Eventually I want to add a helper to zero parts of a sglist to
lib/scatterlist.c, but I don't want to burden that on you.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-04 12:40 +0200
  Re: [PATCH v4 3/8] nvmet: implement namespace identify descriptor  list Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:10 +0200
  Re: [PATCH v4 3/8] nvmet: implement namespace identify descriptor         list Christoph Hellwig <hch@lst.de> - 2017-06-05 07:40 +0200
    Re: [PATCH v4 3/8] nvmet: implement namespace identify descriptor  list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 14:10 +0200
  Re: [PATCH v4 3/8] nvmet: implement namespace identify descriptor  list Hannes Reinecke <hare@suse.de> - 2017-06-06 08:30 +0200

csiph-web