Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1657203

Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP

Show all headers | View raw

Ross Zwisler <ross.zwisler@linux.intel.com> writes:

> On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@intel.com>
>> 
>> The .rw_page in struct block_device_operations is used by the swap
>> subsystem to read/write the page contents from/into the corresponding
>> swap slot in the swap device.  To support the THP (Transparent Huge
>> Page) swap optimization, the .rw_page is enhanced to support to
>> read/write THP if possible.
>> 
>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Cc: Minchan Kim <minchan@kernel.org>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: Ross Zwisler <ross.zwisler@intel.com>
>> Cc: Vishal L Verma <vishal.l.verma@intel.com>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Cc: linux-nvdimm@lists.01.org
>> ---
>>  drivers/block/brd.c           |  6 +++++-
>>  drivers/block/zram/zram_drv.c |  2 ++
>>  drivers/nvdimm/btt.c          |  4 +++-
>>  drivers/nvdimm/pmem.c         | 42 +++++++++++++++++++++++++++++++-----------
>>  4 files changed, 41 insertions(+), 13 deletions(-)
>
> The changes in brd.c, zram_drv.c and pmem.c look good to me.  For those bits
> you can add: 
>
> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Thanks!

> I think we still want Vishal to make sure that the BTT changes are okay.  I
> don't know that code well enough to know whether it's safe to throw 512 pages
> at btt_[read|write]_pg().
>
> Also, Ying, next time can you please CC me (and probably the linux-nvdimm
> list) on the whole series?  It would give us more context on what the larger
> change is, allow us to see the cover letter, allow us to test with all the
> patches in the series, etc.  It's pretty easy for reviewers to skip over the
> patches we don't care about or aren't in our area.

Sure.

Best Regards,
Huang, Ying

> Thanks,
> - Ross

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -mm 00/13] mm, THP, swap: Delay splitting THP after swapped out "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 08:50 +0200
  [PATCH -mm 06/13] block: Increase BIO_MAX_PAGES to PMD size if THP_SWAP enabled "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 08:50 +0200
    Re: [PATCH -mm 06/13] block: Increase BIO_MAX_PAGES to PMD size if  THP_SWAP enabled Ming Lei <ming.lei@redhat.com> - 2017-05-25 10:50 +0200
      Re: [PATCH -mm 06/13] block: Increase BIO_MAX_PAGES to PMD size if THP_SWAP enabled "Huang\, Ying" <ying.huang@intel.com> - 2017-05-26 03:00 +0200
  [PATCH -mm 01/13] mm, THP, swap: Support to clear swap cache flag for THP swapped out "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 08:50 +0200
  [PATCH -mm 13/13] mm, THP, swap: Add THP swapping out fallback counting "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 08:50 +0200
  [PATCH -mm 09/13] memcg, THP, swap: Support move mem cgroup charge for THP swapped out "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 08:50 +0200
  [PATCH -mm 04/13] mm, THP, swap: Don't allocate huge cluster for file backed swap device "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 09:00 +0200
  [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 09:00 +0200
    Re: [PATCH -mm 05/13] block, THP: Make  block_device_operations.rw_page support THP Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-06-02 08:00 +0200
      Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP "Huang\, Ying" <ying.huang@intel.com> - 2017-06-05 03:10 +0200
  [PATCH -mm 03/13] mm, THP, swap: Make reuse_swap_page() works for THP swapped out "Huang, Ying" <ying.huang@intel.com> - 2017-05-25 09:00 +0200

csiph-web