Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656667

Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data

From Namhyung Kim <namhyung@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data
Date 2017-06-03 03:50 +0200
Message-ID <tO6mu-v6-5@gated-at.bofh.it> (permalink)
References <tNuhb-Bs-3@gated-at.bofh.it> <tNwsF-1V9-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Jiri,

On Thu, Jun 1, 2017 at 8:29 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Thu, Jun 01, 2017 at 06:06:04PM +0900, Namhyung Kim wrote:
>
> SNIP
>
>> @@ -399,6 +438,7 @@ static int __open_dso(struct dso *dso, struct machine *machine)
>>       int fd;
>>       char *root_dir = (char *)"";
>>       char *name = malloc(PATH_MAX);
>> +     bool needs_unlink = false;
>>
>>       if (!name)
>>               return -ENOMEM;
>> @@ -415,7 +455,23 @@ static int __open_dso(struct dso *dso, struct machine *machine)
>>       if (!is_regular_file(name))
>>               return -EINVAL;
>>
>> +     if (dso__needs_decompress(dso)) {
>> +             char buf[32];
>> +
>> +             fd = dso__decompress_kmodule(dso, name, buf, sizeof(buf));
>> +             if (fd < 0)
>
>                         free(name)

ok.

>
>> +                     return -1;
>> +
>> +             close(fd);
>> +             strcpy(name, buf);
>
> also why not use name directly instead of buf?

The name should have original compressed filename and buf will be set
to a new decompressed name.

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf tools: Decompress kernel module when reading DSO data Namhyung Kim <namhyung@kernel.org> - 2017-06-01 11:10 +0200
  [PATCH 2/2] perf test: Decompress kernel module before objdump Namhyung Kim <namhyung@kernel.org> - 2017-06-01 11:10 +0200
  Re: [PATCH 1/2] perf tools: Decompress kernel module when reading  DSO data Jiri Olsa <jolsa@redhat.com> - 2017-06-01 13:30 +0200
    Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data Namhyung Kim <namhyung@kernel.org> - 2017-06-03 03:50 +0200
  Re: [PATCH 1/2] perf tools: Decompress kernel module when reading  DSO data Jiri Olsa <jolsa@redhat.com> - 2017-06-01 13:40 +0200
    Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data Namhyung Kim <namhyung@kernel.org> - 2017-06-03 03:50 +0200

csiph-web