Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656651

Re: [PATCH] regmap: make LZO cache optional

Show all headers | View raw

On Fri, Jun 02, 2017 at 03:15:37PM +0200, Jonas Gorski wrote:
> Commit 2cbbb579bcbe3 ("regmap: Add the LZO cache support") added support
> for LZO compression in regcache, but there were never any users added
> afterwards. Since LZO support itself has its own size, it currently is
> rather a deoptimization.
> 
> So make it optional by introducing a symbol that can be selected by
> drivers wanting to make use of it.
> 
> Saves e.g. ~46 kB on MIPS (size of LZO support + regcache LZO code).
> 
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
> I tried using google to find any users (even out-of-tree ones), but at
> best I found a single driver submission that was switched to RBTREE in
> subsequent resubmissions (MFD_SMSC).
> 
> One could maybe also just drop the code because of no users for 5 years,
> but that would be up to the maintainer(s) to decide.

Let's just drop it, if there are no users, it shouldn't be there at all.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regmap: make LZO cache optional Jonas Gorski <jonas.gorski@gmail.com> - 2017-06-02 15:20 +0200
  Re: [PATCH] regmap: make LZO cache optional Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-03 03:00 +0200
  Applied "regmap: make LZO cache optional" to the regmap tree Mark Brown <broonie@kernel.org> - 2017-06-06 21:20 +0200

csiph-web