Re: powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function

From	Michael Ellerman <patch-notifications@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function
Date	2017-06-01 15:40 +0200
Message-ID	<tNyut-38G-1@gated-at.bofh.it> (permalink)
References	<tKzwJ-88W-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-05-24 at 08:01:55 UTC, Christophe Leroy wrote:
> of_mm_gpiochip_add_data() generates an Oops for NULL pointer dereference.
> 
> of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
> setting the data, therefore ->save_regs() cannot use gpiochip_get_data()
> 
> Fixes: 937daafca774b ("powerpc: simple-gpio: use gpiochip data pointer")
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/6f553912eedafae13ff20b322a65e4

cheers

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-06-01 15:40 +0200

csiph-web