Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1655002

Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

Show all headers | View raw

On 01/06/2017 06:41, Christoph Hellwig wrote:
>> +	case SAS_PROTOCOL_SSP:
>> +	{
>> +		unsigned char op = task->ssp_task.cmd->cmnd[0];
>> +
>> +		if (op == READ_6 || op == WRITE_6 ||
>> +			op == READ_10 || op == WRITE_10 ||
>> +			op == READ_12 || op == WRITE_12 ||
>> +			op == READ_16 || op == WRITE_16)
>> +			return true;
>> +		break;
>> +	}
>
> Wee. why do you care?  >

In the command completion code we need to check for abnormal completion 
due to underflow, but ignore it when it occurs in some commands, like 
inquiry. This is why we check for rw command - it is equivalent to !inquiry.

I'll see if we can change the check to explicitly ignore certain 
commands which complete abnormally with underflow.

>What about 32-byte CDs or things like Write Same?
>

You're talking about VARIABLE_LENGTH_CMD (opcode 0x7f) for 32-byte CDs, 
right?

I need to check on WRITE SAME.

> .
>

Thanks,
John

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/23] hisi_sas: hip08 support John Garry <john.garry@huawei.com> - 2017-05-31 16:10 +0200
  [PATCH v3 12/23] scsi: hisi_sas: add v3 hw PHY init John Garry <john.garry@huawei.com> - 2017-05-31 16:10 +0200
  [PATCH v3 08/23] scsi: hisi_sas: create hisi_sas_get_fw_info() John Garry <john.garry@huawei.com> - 2017-05-31 16:10 +0200
  [PATCH v3 19/23] scsi: hisi_sas: add v3 code to send internal abort command John Garry <john.garry@huawei.com> - 2017-05-31 16:10 +0200
  [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler John Garry <john.garry@huawei.com> - 2017-05-31 16:10 +0200
    Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler Christoph Hellwig <hch@infradead.org> - 2017-06-01 07:50 +0200
      Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler John Garry <john.garry@huawei.com> - 2017-06-01 12:50 +0200
  [PATCH v3 15/23] scsi: hisi_sas: add v3 code to send SSP frame John Garry <john.garry@huawei.com> - 2017-05-31 16:10 +0200
  [PATCH v3 10/23] scsi: hisi_sas: add initialisation for v3 pci-based controller John Garry <john.garry@huawei.com> - 2017-05-31 16:10 +0200
  [PATCH v3 11/23] scsi: hisi_sas: add v3 hw init John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 21/23] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 02/23] scsi: hisi_sas: define hisi_sas_device.device_id as int John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 09/23] scsi: hisi_sas: add skeleton v3 hw driver John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 06/23] scsi: hisi_sas: relocate get_ncq_tag_v2_hw() John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 07/23] scsi: hisi_sas: add pci_dev in hisi_hba struct John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 03/23] scsi: hisi_sas: optimise the usage of hisi_hba.lock John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 01/23] scsi: hisi_sas: fix timeout check in hisi_sas_internal_task_abort() John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 16/23] scsi: hisi_sas: add v3 code to send SMP frame John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 04/23] scsi: hisi_sas: relocate get_ata_protocol() John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 23/23] scsi: hisi_sas: modify internal abort dev flow for v3 hw John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200
  [PATCH v3 05/23] scsi: hisi_sas: relocate sata_done_v2_hw() John Garry <john.garry@huawei.com> - 2017-05-31 16:20 +0200

csiph-web