Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables

From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables
Date	2017-06-01 11:40 +0200
Message-ID	<tNuKe-LA-31@gated-at.bofh.it> (permalink)
References	<tI4nn-1Pa-9@gated-at.bofh.it> <tI4nn-1Pa-7@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Wed, 17 May 2017 13:25:13 +0300, Mika Westerberg wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Make sure dmi_system_id tables are NULL terminated.
> 
> Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 2debba62fac9..e35d0fe4c737 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
>  			DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
>  		},
> -	}
> +	},
> +	{}
>  };
>  
>  static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq)

Reviewed-by: Jean Delvare <jdelvare@suse.de>

This should go to stable trees IMHO.

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for  dmi_system_id tables Jean Delvare <jdelvare@suse.de> - 2017-06-01 11:40 +0200

csiph-web