Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust for PIO mode

From	Jiada Wang <jiada_wang@mentor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust for PIO mode
Date	2017-06-01 10:00 +0200
Message-ID	<tNtbr-89x-3@gated-at.bofh.it> (permalink)
References	<tLfFE-1Dm-5@gated-at.bofh.it> <tMqIF-7su-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Fabio

On 05/29/2017 04:07 AM, Fabio Estevam wrote:
> Hi Jiada,
>
> On Fri, May 26, 2017 at 2:02 AM,<jiada_wang@mentor.com>  wrote:
>> From: Jiada Wang<jiada_wang@mentor.com>
>>
>> previously burst length (BURST_LENGTH) is always set to equal
>> to bits_per_word, causes a 10us gap between each word in
>> transfer, which significantly affects performance.
>>
>> This patch uses 32 bits transfer to simulate lower bits transfer,
>> and adjusts burst length runtimely to use biggeest burst length
>> as possible to reduce the gaps in transfer for PIO mode.
> Just curious: what is the performance gain you observe with this patch?
I did some performance test with 576/384/192 bytes data,
following is the result between the test w & w/o this patch
(ecspi controller works in PIO and loopback mode)

with this patch:
bytes      bpw      time (ms)
576         8           9.2
576         16         9.2
384         8            6.2
192          8           3.1

without this patch
bytes      bpw      time(ms)
576           8           14.4
576           16          11.6
384           8            9.6
384           16          7.8
192           8            4.8
192           16          3.9


Thanks,
Jiada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust for PIO mode <jiada_wang@mentor.com> - 2017-05-26 07:10 +0200
  Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust  for PIO mode Sascha Hauer <s.hauer@pengutronix.de> - 2017-05-29 12:00 +0200
    Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust  for PIO mode Jiada Wang <jiada_wang@mentor.com> - 2017-06-01 14:00 +0200
      Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust  for PIO mode Sascha Hauer <s.hauer@pengutronix.de> - 2017-06-02 07:40 +0200
  Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust  for PIO mode Fabio Estevam <festevam@gmail.com> - 2017-05-29 13:10 +0200
    Re: [PATCH linux-next v3 1/1] spi: imx: dynamic burst length adjust  for PIO mode Jiada Wang <jiada_wang@mentor.com> - 2017-06-01 10:00 +0200

csiph-web