[PATCH] cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Jia-Ju Bai <baijiaju1990@163.com>
Newsgroups	linux.kernel
Subject	[PATCH] cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm
Date	Thu, 01 Jun 2017 04:40:01 +0200
Message-ID	<tNobL-52F-9@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=5Sei9z/WxfTc94f9nU 3RHV9Ztx0CA7ugF0NT6jWPjdg=; b=dG9Sio3D47UD3CW2z+LnkGshRp4TO4521T uXJ44TeS9nRoU2BylhYpM+YlOdJoK5dKiAr6bhHmDklQZP25bNjsceCoMYf69DvN RrvfgkXPghDeOjXKwGNJO3OmMIpp/Atxit68y/v4zRaTTixEIlZ+3oMzIpSJg34O GvMffLuKw=
X-Mailer	git-send-email 1.7.9.5
X-Cm-Transid	DsCowADnJWIWfS9Z9spOIQ--.19495S2
X-Coremail-Antispam	1Uf129KBjvdXoW7XryfCw18tFy5ZryDCFyfJFb_yoWkArbEkF 9agFy0qw4rAwnIvw1rurW3Zr4Ik3Z5Z3Wxuw4xKFZxCayDXFWUXa93AFW5Jrn8uF4kuFZx Gw1DWw1rArnFgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjiIDDUUUUU==
X-Originating-IP	[166.111.70.19]
X-Cm-Senderinfo	xedlyx5dmximizq6il2tof0z/1tbiGBnpelXlZ0cDUwAAsS
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai <baijiaju1990@163.com>
X-Original-Date	Thu, 1 Jun 2017 10:36:14 +0800
X-Original-Message-ID	<1496284574-11056-1-git-send-email-baijiaju1990@163.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1654764

Show key headers only | View raw

The driver may sleep under a spin lock, and the function call path is:
cw1200_tx_confirm_cb (acquire the lock by spin_lock)
  __cw1200_cqm_bssloss_sm
    cancel_work_sync --> may sleep

cw1200_cqm_bssloss_sm
  __cw1200_cqm_bssloss_sm
    cancel_work_sync --> may sleep

To fix it, the lock is released before cancel_work_sync, and the lock 
is acquired again after this function.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
 drivers/net/wireless/st/cw1200/sta.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/st/cw1200/sta.c b/drivers/net/wireless/st/cw1200/sta.c
index a522248..d5f7698 100644
--- a/drivers/net/wireless/st/cw1200/sta.c
+++ b/drivers/net/wireless/st/cw1200/sta.c
@@ -154,7 +154,9 @@ void __cw1200_cqm_bssloss_sm(struct cw1200_common *priv,
 	int tx = 0;
 
 	priv->delayed_link_loss = 0;
+	spin_unlock(&priv->bss_loss_lock);
 	cancel_work_sync(&priv->bss_params_work);
+	spin_lock(&priv->bss_loss_lock);
 
 	pr_debug("[STA] CQM BSSLOSS_SM: state: %d init %d good %d bad: %d txlock: %d uj: %d\n",
 		 priv->bss_loss_state,
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm Jia-Ju Bai <baijiaju1990@163.com> - 2017-06-01 04:40 +0200
  Re: cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and  cw1200_cqm_bssloss_sm Kalle Valo <kvalo@codeaurora.org> - 2017-06-01 11:50 +0200

csiph-web