[PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value instead of LED_FULL

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value instead of LED_FULL
Date	2017-06-01 03:50 +0200
Message-ID	<tNnpo-4r2-5@gated-at.bofh.it> (permalink)
References	<tNnpo-4r2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit 4e552c8cb5bc ("leds: add LED_ON brightness as boolean value")
has introduced the LED_ON enumeration value that can be used
instead of LED_FULL which has more of a linear value.

Because the tm2-touchscreen doesn't have brightness levels, but
it's a simple on/off led, use LED_ON instead of LED_FULL.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reviewed-by: Jaechul Lee <jcsing.lee@samsung.com>
Tested-by: Jaechul Lee <jcsing.lee@samsung.com>
---
Hi Dmitry,

this is the second version of this simple patch sent here:

https://marc.info/?l=linux-kernel&m=149062143701658&w=2

no changes, just added Jaechul's review and test.

Andi

 drivers/input/keyboard/tm2-touchkey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c
index 485900f953e0..abc266e40e17 100644
--- a/drivers/input/keyboard/tm2-touchkey.c
+++ b/drivers/input/keyboard/tm2-touchkey.c
@@ -213,7 +213,7 @@ static int tm2_touchkey_probe(struct i2c_client *client,
 	/* led device */
 	touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME;
 	touchkey->led_dev.brightness = LED_FULL;
-	touchkey->led_dev.max_brightness = LED_FULL;
+	touchkey->led_dev.max_brightness = LED_ON;
 	touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set;
 
 	error = devm_led_classdev_register(&client->dev, &touchkey->led_dev);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value  instead of LED_FULL Andi Shyti <andi.shyti@samsung.com> - 2017-06-01 03:50 +0200
  Re: [PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value  instead of LED_FULL Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-02 07:10 +0200

csiph-web