Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654676

Re: [PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while load/unload module test

Show all headers | View raw

On Fri, Jun 2, 2017 at 12:33 AM,  <priyalee.kushwaha@intel.com> wrote:
> This fix oops found while testing load/unload test of
> intel_telemetry_debugfs module. Module_init uses register_pm_notifier
> for PM callbacks, but unregister_pm_notifier was missing from
> module_exit.

> +#ifdef CONFIG_PM_SLEEP
> +       unregister_pm_notifier(&pm_notifier);
> +#endif /* CONFIG_PM_SLEEP */

Neither here

> +#ifdef CONFIG_PM_SLEEP
> +       unregister_pm_notifier(&pm_notifier);
> +#endif /* CONFIG_PM_SLEEP */

Not there.

AFAIU we discussed to make unregister_pm_notifier() having stubs for !PM_SLEEP.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while load/unload module test priyalee.kushwaha@intel.com - 2017-05-31 23:40 +0200
  Re: [PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while  load/unload module test Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-01 00:20 +0200
    RE: [PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while  load/unload module test "Kushwaha, Priyalee" <priyalee.kushwaha@intel.com> - 2017-06-01 00:40 +0200

csiph-web