Re: [PATCH 1/3] regmap: Add 1-Wire bus support

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] regmap: Add 1-Wire bus support
Date	2017-05-31 20:30 +0200
Message-ID	<tNgxA-8mG-29@gated-at.bofh.it> (permalink)
References	<tMTB0-1Xw-7@gated-at.bofh.it> <tMTB0-1Xw-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, May 30, 2017 at 08:57:33PM +0300, Alex A. Mihaylov wrote:

> +	if (!w1_reset_select_slave(sl)) {
> +		w1_write_8(sl->master, W1_CMD_READ_DATA);
> +		w1_write_8(sl->master, reg);
> +		*val = w1_read_8(sl->master);
> +	} else
> +		ret = -ENODEV;

CodingStyle says { } on both sides of an if statement if they're on one.
Otherwise this looks good.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Battery monitor MAX1721x with w1-regmap and w1-slave (resend) "Alex A. Mihaylov" <minimumlaw@rambler.ru> - 2017-05-30 20:00 +0200
  [PATCH 3/3] power: supply: Add support MAX1721x battery monitor "Alex A. Mihaylov" <minimumlaw@rambler.ru> - 2017-05-30 20:00 +0200
  [PATCH 1/3] regmap: Add 1-Wire bus support "Alex A. Mihaylov" <minimumlaw@rambler.ru> - 2017-05-30 20:00 +0200
    Re: [PATCH 1/3] regmap: Add 1-Wire bus support Mark Brown <broonie@kernel.org> - 2017-05-31 20:30 +0200

csiph-web