Re: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling

From	Keith Busch <keith.busch@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling
Date	2017-05-31 18:20 +0200
Message-ID	<tNevM-77a-23@gated-at.bofh.it> (permalink)
References	<tKFsu-3ss-7@gated-at.bofh.it> <tLkci-4g5-31@gated-at.bofh.it> <tMNYB-6Sw-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 30, 2017 at 02:58:06PM +0300, Sagi Grimberg wrote:
> > So, the reason the state is changed when the work is running rather than
> > queueing is for the window when the state may be set to NVME_CTRL_DELETING,
> > and we don't want the reset work to proceed in that case.
> > 
> > What do you think about adding a new state, like NVME_CTRL_SCHED_RESET,
> > then leaving the NVME_CTRL_RESETTING state change as-is?
> 
> OK, just got to this one.
> 
> Instead of adding yet another state, how about making controller delete
> cancel the reset_work (cancel_work_sync)?

Yes, that should also work.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling Keith Busch <keith.busch@intel.com> - 2017-05-26 12:00 +0200
  Re: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling Rakesh Pandit <rakesh@tuxera.com> - 2017-05-26 17:30 +0200
  Re: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling Sagi Grimberg <sagi@grimberg.me> - 2017-05-30 14:00 +0200
    Re: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling Keith Busch <keith.busch@intel.com> - 2017-05-31 18:20 +0200

csiph-web