strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer
Date	2017-05-31 18:10 +0200
Message-ID	<tNem6-73N-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Tom,
I have stumbled over the following construct in xgbe_map_rx_buffer
	order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0);
which looks quite suspicious. Why does it PAGE_ALLOC_COSTLY_ORDER - 1?
And why do you depend on PAGE_ALLOC_COSTLY_ORDER at all?

Thanks!
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer Michal Hocko <mhocko@kernel.org> - 2017-05-31 18:10 +0200
  Re: strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer Michal Hocko <mhocko@kernel.org> - 2017-06-02 16:50 +0200

csiph-web