Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654223

Re: [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc()

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc()
Date 2017-05-31 15:20 +0200
Message-ID <tNbHA-5dQ-11@gated-at.bofh.it> (permalink)
References <tMXbz-4e6-11@gated-at.bofh.it> <tMXbA-4e6-33@gated-at.bofh.it> <tN9Ps-424-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, May 31, 2017 at 4:13 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, May 30, 2017 at 02:39:51PM -0700, Kees Cook wrote:
>> The coming x86 refcount protection needs to be able to add trailing
>> instructions to the GEN_*_RMWcc() operations. This extracts the
>> difference between the goto/non-goto cases so the helper macros
>> can be defined outside the #ifdef cases. Additionally adds argument
>> naming to the resulting asm for referencing from suffixed
>> instructions, and adds clobbers for "cc", and "cx" to let suffixes
>> use _ASM_CX, and retain any set flags.
>
> Another option is to simply require __GCC_ASM_FLAG_OUTPUT__ for the fast
> refcount stuff. That would result in simpler and more readable code.

What versions of GCC support that?

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/3] Implement fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-05-30 23:50 +0200
  [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc() Kees Cook <keescook@chromium.org> - 2017-05-30 23:50 +0200
    Re: [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc() Peter Zijlstra <peterz@infradead.org> - 2017-05-31 13:20 +0200
      Re: [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc() Kees Cook <keescook@chromium.org> - 2017-05-31 15:20 +0200
        Re: [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc() Peter Zijlstra <peterz@infradead.org> - 2017-05-31 16:10 +0200
          Re: [PATCH v5 2/3] x86/asm: Add suffix macro for GEN_*_RMWcc() Kees Cook <keescook@chromium.org> - 2017-05-31 18:10 +0200
  Re: [PATCH v5 0/3] Implement fast refcount overflow protection Davidlohr Bueso <dave@stgolabs.net> - 2017-05-31 14:30 +0200
    Re: [PATCH v5 0/3] Implement fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-05-31 15:30 +0200

csiph-web