Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1656462

Re: [PATCH v2 07/18] xen/pvcalls: implement socket command

From Stefano Stabellini <sstabellini@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 07/18] xen/pvcalls: implement socket command
Date 2017-06-02 20:40 +0200
Message-ID <tNZEm-4Mu-11@gated-at.bofh.it> (permalink)
References <tIZlE-Tg-7@gated-at.bofh.it> <tIZvj-Xm-3@gated-at.bofh.it> <tIZvl-Xm-45@gated-at.bofh.it> <tLpOG-7Ks-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 26 May 2017, Boris Ostrovsky wrote:
> >  static int pvcalls_back_socket(struct xenbus_device *dev,
> >  		struct xen_pvcalls_request *req)
> >  {
> > -	return 0;
> > +	struct pvcalls_back_priv *priv;
> > +	int ret;
> > +	struct xen_pvcalls_response *rsp;
> > +
> > +	priv = dev_get_drvdata(&dev->dev);
> > +
> > +	if (req->u.socket.domain != AF_INET ||
> > +	    req->u.socket.type != SOCK_STREAM ||
> > +	    (req->u.socket.protocol != 0 &&
> > +	     req->u.socket.protocol != AF_INET))
> 
> Shouldn't this be one of IPPROTO_* macros?

Ah yes, I could use IPPROTO_IP instead of 0 here

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 07/18] xen/pvcalls: implement socket command Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-05-26 18:00 +0200
  Re: [PATCH v2 07/18] xen/pvcalls: implement socket command Stefano Stabellini <sstabellini@kernel.org> - 2017-06-02 20:40 +0200

csiph-web