Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t
Date	2017-06-02 14:20 +0200
Message-ID	<tNTIC-Vj-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <tK6l3-4mN-1@gated-at.bofh.it> <tKcgN-8mw-7@gated-at.bofh.it> <tKcTx-a4-47@gated-at.bofh.it> <tNsyK-7UU-13@gated-at.bofh.it> <tNuhc-Bs-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Jun 01, 2017 at 11:07:46AM +0200, Arnd Bergmann wrote:
> On Thu, Jun 1, 2017 at 9:17 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 05/23, Arnd Bergmann wrote:
> >> On Tue, May 23, 2017 at 9:19 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> >> An alternative would be to remove all the dependencies as 'lib-y'
> >> in the Makefile and remove the individual Kconfig symbols. That
> >> way, we would always build all of them when CONFIG_SUNXI_CCU
> >> is enabled, but the linker would drop the ones that do not get
> >> referenced.
> >
> > In this case you're right, and we should change them to lib-y in
> > the Makefile and then let the linker figure this all out. No more
> > dependency patches. I think we only need to do this sort of
> > Kconfig stuff when we want to make a library .ko file that each
> > SoC specific driver depends on for common code.
> >
> > It would be cool if the build system could figure that all out
> > for us, and let us have something like modlib-y that makes it a
> > library (archive) if all objects depending on it are builtin and
> > we have CONFIG_MODULES=n, or makes it into an object file if
> > something is builtin that depends on it, or makes it into a
> > module if everything that depends on it is a module.
> 
> In this case, there are no loadable modules, the sunxi clk drivers
> can only be built-in, which should simplify the problem a lot.

Using the linker to drop the useless stuff seems like a good idea. Do
you want to send a patch for it?

Maxim

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t Stephen Boyd <sboyd@codeaurora.org> - 2017-06-01 09:20 +0200
  Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t Arnd Bergmann <arnd@arndb.de> - 2017-06-01 11:10 +0200
    Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-02 14:20 +0200
      [PATCH] clk: sunxi-ng: Move all clock types to a library Stephen Boyd <sboyd@codeaurora.org> - 2017-06-03 00:40 +0200
        Re: [PATCH] clk: sunxi-ng: Move all clock types to a library Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-05 16:50 +0200
          Re: [PATCH] clk: sunxi-ng: Move all clock types to a library Arnd Bergmann <arnd@arndb.de> - 2017-06-06 12:10 +0200
            Re: [PATCH] clk: sunxi-ng: Move all clock types to a library Stephen Boyd <sboyd@codeaurora.org> - 2017-06-07 00:10 +0200
            Re: [PATCH] clk: sunxi-ng: Move all clock types to a library Chen-Yu Tsai <wens@csie.org> - 2017-06-07 07:50 +0200
              Re: [PATCH] clk: sunxi-ng: Move all clock types to a library Arnd Bergmann <arnd@arndb.de> - 2017-06-07 09:40 +0200
                Re: [PATCH] clk: sunxi-ng: Move all clock types to a library Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-07 10:20 +0200

csiph-web