Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1656148

[PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

From Henri Roosen <henri.roosen@ginzinger.com>
Newsgroups linux.kernel
Subject [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops
Date 2017-06-02 13:40 +0200
Message-ID <tNT5T-rX-15@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


A device might not have an ops structure registered. This
patch fixes a null-prt dereference by checking ops before dereferencing
it.

Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
---
 drivers/rpmsg/rpmsg_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
index 600f5f9..0c48452 100644
--- a/drivers/rpmsg/rpmsg_core.c
+++ b/drivers/rpmsg/rpmsg_core.c
@@ -429,7 +429,7 @@ static int rpmsg_dev_probe(struct device *dev)
 		goto out;
 	}
 
-	if (rpdev->ops->announce_create)
+	if (rpdev->ops && rpdev->ops->announce_create)
 		err = rpdev->ops->announce_create(rpdev);
 out:
 	return err;
-- 
2.1.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops Henri Roosen <henri.roosen@ginzinger.com> - 2017-06-02 13:40 +0200
  Re: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices  without ops Suman Anna <s-anna@ti.com> - 2017-06-02 23:50 +0200

csiph-web