Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1656110

Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

From Felipe Balbi <felipe.balbi@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()
Date 2017-06-02 12:20 +0200
Message-ID <tNRQu-87W-19@gated-at.bofh.it> (permalink)
References <tIrDk-1Ek-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi,

kbuild test robot <lkp@intel.com> writes:
> Hi Felipe,
>
> [auto build test ERROR on tip/perf/core]
> [also build test ERROR on v4.12-rc1 next-20170518]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Felipe-Balbi/kernel-trace-pass-export-pointer-as-argument-to-write/20170518-135452
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
>
> All errors (new ones prefixed by >>):
>
>    drivers/hwtracing/stm/ftrace.c: In function 'stm_ftrace_write':
>>> drivers/hwtracing/stm/ftrace.c:49:19: error: incompatible type for argument 1 of 'stm_source_write'
>      stm_source_write(stm->data, STM_FTRACE_CHAN, buf, len);
>                       ^~~
>    In file included from drivers/hwtracing/stm/ftrace.c:18:0:
>    include/linux/stm.h:136:13: note: expected 'struct stm_source_data *' but argument is of type 'struct stm_source_data'
>     int notrace stm_source_write(struct stm_source_data *data, unsigned int chan,
>                 ^~~~~~~~~~~~~~~~
>
> vim +/stm_source_write +49 drivers/hwtracing/stm/ftrace.c
>
>     43	 */
>     44	static void notrace
>     45	stm_ftrace_write(struct trace_export *export, const void *buf, unsigned int len)
>     46	{
>     47		struct stm_ftrace *stm = container_of(export, struct stm_ftrace, ftrace);
>     48	
>   > 49		stm_source_write(stm->data, STM_FTRACE_CHAN, buf, len);

sorry, just came back from vacations and noticed this. I'll send a v2 shortly.

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] kernel: trace: pass export pointer as argument to ->write() Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-06-02 12:20 +0200

csiph-web