Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1655973

[PATCH v5 05/11] gpio: exar: Fix iomap request

Show all headers | View raw

The UART driver already maps the resource for us. Trying to do this here
only fails and leaves us with a non-working device.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-exar.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
index 65126fa1e512..b29890b143ce 100644
--- a/drivers/gpio/gpio-exar.c
+++ b/drivers/gpio/gpio-exar.c
@@ -125,14 +125,10 @@ static int gpio_exar_probe(struct platform_device *pdev)
 	int index, ret;
 
 	/*
-	 * Map the pci device to get the register addresses.
-	 * We will need to read and write those registers to control
-	 * the GPIO pins.
-	 * Using managed functions will save us from unmaping on exit.
-	 * As the device is enabled using managed functions by the
-	 * UART driver we can also use managed functions here.
+	 * The UART driver must have mapped region 0 prior to registering this
+	 * device - use it.
 	 */
-	p = pcim_iomap(pcidev, 0, 0);
+	p = pcim_iomap_table(pcidev)[0];
 	if (!p)
 		return -ENOMEM;
 
-- 
2.12.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 00/11] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:30 +0200
  [PATCH v5 01/11] serial: exar: Leave MPIOs as output for Commtech adapters Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:30 +0200
  [PATCH v5 04/11] gpio: exar: Allocate resources on behalf of the platform device Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:30 +0200
  [PATCH v5 11/11] serial: exar: Add support for IOT2040 device Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
  [PATCH v5 05/11] gpio: exar: Fix iomap request Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
  [PATCH v5 02/11] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
  [PATCH v5 08/11] serial: exar: Factor out platform hooks Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
  [PATCH v5 07/11] gpio-exar/8250-exar: Rearrange gpiochip parenthood Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
  [PATCH v5 10/11] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
    Re: [PATCH v5 10/11] gpio-exar/8250-exar: Make set of exported GPIOs configurable Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-02 12:40 +0200
  [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
  [PATCH v5 06/11] gpio: exar: Fix reading of directions and values Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200
  [PATCH v5 09/11] platform: Accept const properties Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-02 09:40 +0200

csiph-web