Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1655904

[PATCH 4/6] spi: imx: drop bogus unnecessary dma config

From Sascha Hauer <s.hauer@pengutronix.de>
Newsgroups linux.kernel
Subject [PATCH 4/6] spi: imx: drop bogus unnecessary dma config
Date 2017-06-02 07:40 +0200
Message-ID <tNNtw-4Pq-15@gated-at.bofh.it> (permalink)
References <tNNtw-4Pq-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


It's unnecessary to call spi_imx_dma_configure() from probe(). It will
be called later anyway again when an actual DMA transfer is prepared.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/spi/spi-imx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 3fa5ccfb45a1..0ec8d816e033 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -965,8 +965,6 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
 		goto err;
 	}
 
-	spi_imx_dma_configure(master, 1);
-
 	init_completion(&spi_imx->dma_rx_completion);
 	init_completion(&spi_imx->dma_tx_completion);
 	master->can_dma = spi_imx_can_dma;
-- 
2.11.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 4/6] spi: imx: drop bogus unnecessary dma config Sascha Hauer <s.hauer@pengutronix.de> - 2017-06-02 07:40 +0200
  Applied "spi: imx: drop bogus unnecessary dma config" to the spi tree Mark Brown <broonie@kernel.org> - 2017-06-06 21:10 +0200

csiph-web