Re: [PATCH v5] KVM: x86: avoid large stack allocations in em_fxrstor

From	Nick Desaulniers <nick.desaulniers@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] KVM: x86: avoid large stack allocations in em_fxrstor
Date	2017-06-02 04:20 +0200
Message-ID	<tNKlX-2SE-7@gated-at.bofh.it> (permalink)
References	<tMBE5-6CW-5@gated-at.bofh.it> <tN2bf-7C4-7@gated-at.bofh.it> <tN9FM-3Xv-13@gated-at.bofh.it> <tNmMG-4cv-5@gated-at.bofh.it> <tNsS6-81U-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 01, 2017 at 09:36:18AM +0200, Paolo Bonzini wrote:
> On 01/06/2017 03:05, Nick Desaulniers wrote:
> > On Wed, May 31, 2017 at 07:01:29AM -0400, Paolo Bonzini wrote:
> >>> +		size = offsetof(struct fxregs_state, xmm_space[16]);
> >> This still has the same issue (it should be multiplied by 4).
> > 
> > I'm still misunderstanding the math here.
> > 
> > Why multiplied by four, in this case? 8 * 16 / 4 is used in other cases.
> 
> *16/4 is the same as *4. :)

I meant the use of an expression full of literals rather than either a
single literal or an expression formed from well named variables seemed
kind of like a code smell, but w/e.  Patch inbound.

Thread

Re: [PATCH] KVM: x86: dynamically allocate large struct in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-25 03:40 +0200
  Re: [PATCH] KVM: x86: dynamically allocate large struct in em_fxrstor Paolo Bonzini <pbonzini@redhat.com> - 2017-05-25 16:10 +0200
    Re: [PATCH] KVM: x86: dynamically allocate large struct in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 06:20 +0200
      Re: [PATCH] KVM: x86: dynamically allocate large struct in em_fxrstor Paolo Bonzini <pbonzini@redhat.com> - 2017-05-26 09:20 +0200
        [PATCH v2] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-29 22:00 +0200
          Re: [PATCH v2] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-29 22:30 +0200
          [PATCH v3] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-29 22:40 +0200
            [PATCH v4] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-30 00:50 +0200
              Re: [PATCH v4] KVM: x86: avoid large stack allocations in em_fxrstor Paolo Bonzini <pbonzini@redhat.com> - 2017-05-30 12:20 +0200
                Re: [PATCH v4] KVM: x86: avoid large stack allocations in em_fxrstor Radim Krčmář <rkrcmar@redhat.com> - 2017-05-30 16:10 +0200
              [PATCH v5] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-31 05:10 +0200
                Re: [PATCH v5] KVM: x86: avoid large stack allocations in  em_fxrstor Paolo Bonzini <pbonzini@redhat.com> - 2017-05-31 13:10 +0200
                Re: [PATCH v5] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-06-01 03:10 +0200
                Re: [PATCH v5] KVM: x86: avoid large stack allocations in em_fxrstor Paolo Bonzini <pbonzini@redhat.com> - 2017-06-01 09:40 +0200
                Re: [PATCH v5] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-06-02 04:20 +0200
            Re: [PATCH v3] KVM: x86: avoid large stack allocations in em_fxrstor Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-30 00:50 +0200

csiph-web