Re: [PATCH 1/2] ARM: dts: rockchip: add usb nodes on rk322x

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	wlf <wulf@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ARM: dts: rockchip: add usb nodes on rk322x
Date	Fri, 02 Jun 2017 03:50:01 +0200
Message-ID	<tNJSV-2n1-1@gated-at.bofh.it> (permalink)
References	<tN0Ct-6qZ-1@gated-at.bofh.it> <tN0Ct-6qZ-5@gated-at.bofh.it> <tNETf-7v6-1@gated-at.bofh.it>
X-263anti-Spam	KSV:0;
X-Mail-Delivery	1
X-Abs-Checked	4
X-Rl-Sender	wulf@rock-chips.com
X-Fst-To	daniel.meng@rock-chips.com
X-Sender-IP	58.22.7.114
X-Login-Name	wulf@rock-chips.com
X-Unique-Tag	<6c6a5a170709c8f78f218dd3fd5a2251>
X-Sender	wulf@rock-chips.com
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version	1.0
Content-Type	text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding	8bit
Content-Language	en-US
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	193
Organization	linux.* mail to news gateway
X-Original-Cc	robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, frank.wang@rock-chips.com, huangtao@rock-chips.com, daniel.meng@rock-chips.com
X-Original-Date	Fri, 2 Jun 2017 09:44:51 +0800
X-Original-Message-ID	<2584cf1a-7ffb-b5ba-3324-fca3f4fd402e@rock-chips.com>
X-Original-References	<1496193684-30449-1-git-send-email-william.wu@rock-chips.com> <1496193684-30449-2-git-send-email-william.wu@rock-chips.com> <1657625.AqxPQItbmB@phil>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1655832

Show key headers only | View raw

Dear Heiko,

在 2017年06月02日 04:22, Heiko Stuebner 写道:
> Hi William,
>
> Am Mittwoch, 31. Mai 2017, 09:21:23 CEST schrieb William Wu:
>> This patch adds usb otg/host controllers and phys nodes on rk322x.
>>
>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>> ---
>>   arch/arm/boot/dts/rk322x.dtsi | 138 +++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 137 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
>> index df57413..d4bfd3c 100644
>> --- a/arch/arm/boot/dts/rk322x.dtsi
>> +++ b/arch/arm/boot/dts/rk322x.dtsi
>> @@ -210,8 +210,61 @@
>>   	};
>>   
>>   	grf: syscon@11000000 {
>> -		compatible = "syscon";
>> +		compatible = "syscon", "simple-mfd";
>>   		reg = <0x11000000 0x1000>;
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +
>> +		u2phy0: usb2-phy@760 {
>> +			compatible = "rockchip,rk322x-usb2phy";
> as commented on the driver-side some moments ago, compatibles should not
> contain wildcards, so please make this
> 	"rockchip,rk3228-usb2phy"
> instead.
>
> Same below and also for the dwc2 node.
Thanks, I'll fix it immediately.
>
>
> Thanks
> Heiko
>
>> +			reg = <0x0760 0x0c>;
>> +			clocks = <&cru SCLK_OTGPHY0>;
>> +			clock-names = "phyclk";
>> +			#clock-cells = <0>;
>> +			clock-output-names = "usb480m_phy0";
>> +			status = "disabled";
>> +
>> +			u2phy0_otg: otg-port {
>> +				#phy-cells = <0>;
>> +				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
>> +					     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
>> +					     <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
>> +				interrupt-names = "otg-bvalid", "otg-id",
>> +						  "linestate";
>> +				status = "disabled";
>> +			};
>> +
>> +			u2phy0_host: host-port {
>> +				#phy-cells = <0>;
>> +				interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
>> +				interrupt-names = "linestate";
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>> +		u2phy1: usb2-phy@800 {
>> +			compatible = "rockchip,rk322x-usb2phy";
> rockchip,rk3228-usb2phy
OK, I'll fix it immediately.
>
>> +			reg = <0x0800 0x0c>;
>> +			clocks = <&cru SCLK_OTGPHY1>;
>> +			clock-names = "phyclk";
>> +			#clock-cells = <0>;
>> +			clock-output-names = "usb480m_phy1";
>> +			status = "disabled";
>> +
>> +			u2phy1_otg: otg-port {
>> +				#phy-cells = <0>;
>> +				interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
>> +				interrupt-names = "linestate";
>> +				status = "disabled";
>> +			};
>> +
>> +			u2phy1_host: host-port {
>> +				#phy-cells = <0>;
>> +				interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>> +				interrupt-names = "linestate";
>> +				status = "disabled";
>> +			};
>> +		};
>>   	};
>>   
>>   	uart0: serial@11010000 {
>> @@ -467,6 +520,89 @@
>>   		status = "disabled";
>>   	};
>>   
>> +	usb_otg: usb@30040000 {
>> +		compatible = "rockchip,rk322x-usb", "rockchip,rk3066-usb",
> rockchip,rk3228-usb
OK, I'll fix it immediately.:-)
>
>> +			     "snps,dwc2";
>> +		reg = <0x30040000 0x40000>;
>> +		interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru HCLK_OTG>;
>> +		clock-names = "otg";
>> +		dr_mode = "otg";
>> +		g-np-tx-fifo-size = <16>;
>> +		g-rx-fifo-size = <280>;
>> +		g-tx-fifo-size = <256 128 128 64 32 16>;
>> +		g-use-dma;
>> +		phys = <&u2phy0_otg>;
>> +		phy-names = "usb2-phy";
>> +		status = "disabled";
>> +	};
>> +
>> +	usb_host0_ehci: usb@30080000 {
>> +		compatible = "generic-ehci";
>> +		reg = <0x30080000 0x20000>;
>> +		interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru HCLK_HOST0>, <&u2phy0>;
>> +		clock-names = "usbhost", "utmi";
>> +		phys = <&u2phy0_host>;
>> +		phy-names = "usb";
>> +		status = "disabled";
>> +	};
>> +
>> +	usb_host0_ohci: usb@300a0000 {
>> +		compatible = "generic-ohci";
>> +		reg = <0x300a0000 0x20000>;
>> +		interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru HCLK_HOST0>, <&u2phy0>;
>> +		clock-names = "usbhost", "utmi";
>> +		phys = <&u2phy0_host>;
>> +		phy-names = "usb";
>> +		status = "disabled";
>> +	};
>> +
>> +	usb_host1_ehci: usb@300c0000 {
>> +		compatible = "generic-ehci";
>> +		reg = <0x300c0000 0x20000>;
>> +		interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru HCLK_HOST1>, <&u2phy1>;
>> +		clock-names = "usbhost", "utmi";
>> +		phys = <&u2phy1_otg>;
>> +		phy-names = "usb";
>> +		status = "disabled";
>> +	};
>> +
>> +	usb_host1_ohci: usb@300e0000 {
>> +		compatible = "generic-ohci";
>> +		reg = <0x300e0000 0x20000>;
>> +		interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru HCLK_HOST1>, <&u2phy1>;
>> +		clock-names = "usbhost", "utmi";
>> +		phys = <&u2phy1_otg>;
>> +		phy-names = "usb";
>> +		status = "disabled";
>> +	};
>> +
>> +	usb_host2_ehci: usb@30100000 {
>> +		compatible = "generic-ehci";
>> +		reg = <0x30100000 0x20000>;
>> +		interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru HCLK_HOST2>, <&u2phy1>;
>> +		phys = <&u2phy1_host>;
>> +		phy-names = "usb";
>> +		clock-names = "usbhost", "utmi";
>> +		status = "disabled";
>> +	};
>> +
>> +	usb_host2_ohci: usb@30120000 {
>> +		compatible = "generic-ohci";
>> +		reg = <0x30120000 0x20000>;
>> +		interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru HCLK_HOST2>, <&u2phy1>;
>> +		clock-names = "usbhost", "utmi";
>> +		phys = <&u2phy1_host>;
>> +		phy-names = "usb";
>> +		status = "disabled";
>> +	};
>> +
>>   	gmac: ethernet@30200000 {
>>   		compatible = "rockchip,rk3228-gmac";
>>   		reg = <0x30200000 0x10000>;
>>
>
>
>
>

Thread

[PATCH 0/2] Add usb nodes on rk322x SoCs and enable usb on rk3229 evb William Wu <william.wu@rock-chips.com> - 2017-05-31 03:30 +0200
  [PATCH 1/2] ARM: dts: rockchip: add usb nodes on rk322x William Wu <william.wu@rock-chips.com> - 2017-05-31 03:30 +0200
    Re: [PATCH 1/2] ARM: dts: rockchip: add usb nodes on rk322x Heiko Stuebner <heiko@sntech.de> - 2017-06-01 22:30 +0200
      Re: [PATCH 1/2] ARM: dts: rockchip: add usb nodes on rk322x wlf <wulf@rock-chips.com> - 2017-06-02 03:50 +0200
  [PATCH 2/2] ARM: dts: rockchip: enable usb for rk3229 evb board William Wu <william.wu@rock-chips.com> - 2017-05-31 03:30 +0200

csiph-web