Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support
Date	Fri, 02 Jun 2017 00:30:01 +0200
Message-ID	<tNGLn-eH-1@gated-at.bofh.it> (permalink)
References	<tHZQK-7s4-19@gated-at.bofh.it> <tI00p-7v7-21@gated-at.bofh.it> <tI93J-4Nh-31@gated-at.bofh.it> <tNDkt-6hn-1@gated-at.bofh.it> <tNFYZ-8b0-5@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QMDc97UfZDWlajw2erzCBZ6G8aXvUb48Zc/TtrFQGBM=; b=l9o82ymqFJQD/9q0zYjZ3LDUs39w60tqVNbiXR4gMURAacd/3ZMdC3AKrc8ei+xD06 6Nhi7fw/Rv9j4rduFezmBgV4xYYAA4rdv9zZ7Idk/4HevVmk01voC2tehZXQkqrw7aVk f9fWQvaQteDyF8QNGwDP3H7g++ulhGhWPCHoyG6kjhpsYDIvjArHyyv2u75fgp+qDYys xQOYIWLJg/yfPvcfvzNN0yfF9xWEizkSkr45l5yGf6mjvWzZtBoNPLgb/nxG6oNjoCI7 /4AIPGPlBvGzsvuNsb9QFojfi9STzJ68sGUaFM6f4pGLPDSYBpPiI77FQk5a8HIMetsP uJMg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QMDc97UfZDWlajw2erzCBZ6G8aXvUb48Zc/TtrFQGBM=; b=Zx3acBBP3B3A6WGU0flGjo7T/Zk/sqdB893wJXY1dcIywAJvHT9OEVJSt1GcsFwirx nysnkDxS3TxkZdbB5ZmmrdnxFmNEZp20Mn/SQKqhNuZR0JLmxd/9XQ2Df6Q7rDsDos3d cuE5rxqv4jqPnd4bRQT27E2STW8+xBiWY0SEB+92wnJTB/hkXzTK/yDBZllwFliNRwcH SBQzAZl7ToVNJE1ueKk6L/ztCIdXw45W+pwoOTwU+Fk/tFEQ7V/0eDUmS1KTmFa0JL7H qfIFzZX4B6Ts5QWMyHDzCzufP71boU40CTnI945Vj+zh5fK37wCuPUjibHffGxuNBr7x 5ugw==
X-Gm-Message-State	AODbwcB97iZU8waY6k/R1SCVFAxbhO71wszKtHaj/vorQVReIiOulxpl QEPoytYRFfa75Q==
X-Received	by 10.98.27.194 with SMTP id b185mr3347662pfb.101.1496355803391; Thu, 01 Jun 2017 15:23:23 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Boris Brezillon <boris.brezillon@free-electrons.com>, "dwmw2@infradead.org" <dwmw2@infradead.org>, "andrew@lunn.ch" <andrew@lunn.ch>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
X-Original-Date	Thu, 1 Jun 2017 15:23:20 -0700
X-Original-Message-ID	<20170601222320.GE102137@google.com>
X-Original-References	<20170517053908.26138-1-chris.packham@alliedtelesis.co.nz> <20170517053908.26138-4-chris.packham@alliedtelesis.co.nz> <20170517172911.5f926712@bbrezillon> <20170601184340.GA102137@google.com> <bba73e6d5f4b41a88423287300d892e5@svr-chch-ex1.atlnz.lc>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1655792

Show key headers only | View raw

On Thu, Jun 01, 2017 at 09:30:07PM +0000, Chris Packham wrote:
> On 02/06/17 06:43, Brian Norris wrote:
> > On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote:
> >> Can we fix allocate_partition() to properly handle the
> >> master->erasesize == 0 case instead of doing that?
> >
> > Is everything actually ready for the eraseblock size to be 0?
> 
> That was my initial motivation for faking it.

Understood. I think it's probably better to avoid hacking drivers like
you were about to, but I was also curious if anyone had thought through
the implications of *not* forcing a non-zero size.

> > That would
> > seem surprising to many applications, I would think. Can you, for
> > instance, even use UBI on such a device?
> 
> I've tried ext2 and I believe Andrew has tried minix fs. We're talking 
> SRAM so UBI/UBIFS doesn't really provide much benefit for this use-case.

Right. But that's not necessarily true for all NO_ERASE devices, so we'd
probably want to think about that before allowing it.

Brian

Thread

Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support Brian Norris <computersforpeace@gmail.com> - 2017-06-01 20:50 +0200
  Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-01 22:50 +0200
    Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support Brian Norris <computersforpeace@gmail.com> - 2017-06-02 00:10 +0200
      Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-02 11:10 +0200
  Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-01 23:40 +0200
    Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support Brian Norris <computersforpeace@gmail.com> - 2017-06-02 00:30 +0200
      Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-02 01:10 +0200

csiph-web