Re: [PATCH] tty: add TIOCGPTPEER ioctl

From	Richard Henderson <rth@twiddle.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: add TIOCGPTPEER ioctl
Date	2017-06-01 22:20 +0200
Message-ID	<tNEJz-7rY-5@gated-at.bofh.it> (permalink)
References	<tNCeK-5B8-21@gated-at.bofh.it> <tNDku-6hn-19@gated-at.bofh.it> <tNEzV-7oF-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/01/2017 01:00 PM, Aleksa Sarai wrote:
>>> --- a/arch/alpha/include/uapi/asm/ioctls.h
>>> +++ b/arch/alpha/include/uapi/asm/ioctls.h
>>> @@ -94,6 +94,7 @@
>>>   #define TIOCSRS485     _IOWR('T', 0x2F, struct serial_rs485)
>>>   #define TIOCGPTN       _IOR('T',0x30, unsigned int) /* Get Pty Number (of 
>>> pty-mux device) */
>>>   #define TIOCSPTLCK     _IOW('T',0x31, int)  /* Lock/unlock Pty */
>>> +#define TIOCGPTPEER    _IOR('T', 0x41, int) /* Safely open the slave */
>>
>> Shouldn't the list of definitions be kept sorted, by hex number?
>> (everywhere)
> 
> Probably. The reason I put it here is because it logically is very similar to 
> TIOCGPTN and TIOSPTLCK, but I can move it if the hex order is more important 
> for maintainence.
> 

Yes please.


r~

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tty: add TIOCGPTPEER ioctl Aleksa Sarai <asarai@suse.de> - 2017-06-01 19:40 +0200
  Re: [PATCH] tty: add TIOCGPTPEER ioctl Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-01 20:50 +0200
    Re: [PATCH] tty: add TIOCGPTPEER ioctl Aleksa Sarai <asarai@suse.de> - 2017-06-01 22:10 +0200
      Re: [PATCH] tty: add TIOCGPTPEER ioctl Richard Henderson <rth@twiddle.net> - 2017-06-01 22:20 +0200

csiph-web