Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1655677

Re: [PATCH] mISDN: Fix a sleep-in-atomic bug

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] mISDN: Fix a sleep-in-atomic bug
Date 2017-06-01 21:00 +0200
Message-ID <tNDua-6m6-17@gated-at.bofh.it> (permalink)
References <tN5Vv-1DA-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Jia-Ju Bai <baijiaju1990@163.com>
Date: Wed, 31 May 2017 15:08:25 +0800

> The driver may sleep under a read spin lock, and the function call path is:
> send_socklist (acquire the lock by read_lock)
>   skb_copy(GFP_KERNEL) --> may sleep
> 
> To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>

Just proves that nobody has ever run this code with lock debugging
enabled, if at all.

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] mISDN: Fix a sleep-in-atomic bug Jia-Ju Bai <baijiaju1990@163.com> - 2017-05-31 09:10 +0200
  Re: [PATCH] mISDN: Fix a sleep-in-atomic bug David Miller <davem@davemloft.net> - 2017-06-01 21:00 +0200

csiph-web