Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1655617

[PATCH] ARM: imx: mmdc: Delete an error message for a failed memory allocation in imx_mmdc_perf_init()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 1 Jun 2017 19:15:41 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/arm/mach-imx/mmdc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
index 78262899a590..b073af20e59e 100644
--- a/arch/arm/mach-imx/mmdc.c
+++ b/arch/arm/mach-imx/mmdc.c
@@ -486,10 +486,8 @@ static int imx_mmdc_perf_init(struct platform_device *pdev, void __iomem *mmdc_b
 		of_match_device(imx_mmdc_dt_ids, &pdev->dev);
 
 	pmu_mmdc = kzalloc(sizeof(*pmu_mmdc), GFP_KERNEL);
-	if (!pmu_mmdc) {
-		pr_err("failed to allocate PMU device!\n");
+	if (!pmu_mmdc)
 		return -ENOMEM;
-	}
 
 	/* The first instance registers the hotplug state */
 	if (!cpuhp_mmdc_state) {
-- 
2.13.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] ARM: imx: mmdc: Delete an error message for a failed memory  allocation in imx_mmdc_perf_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 19:30 +0200

csiph-web